[PWGLF] Change Generated Event selection in NucleiSpectra.cxx#15158
Open
Cristian-Moscatelli wants to merge 4 commits intoAliceO2Group:masterfrom
Open
[PWGLF] Change Generated Event selection in NucleiSpectra.cxx#15158Cristian-Moscatelli wants to merge 4 commits intoAliceO2Group:masterfrom
Cristian-Moscatelli wants to merge 4 commits intoAliceO2Group:masterfrom
Conversation
github-actions
bot
changed the title
Contributor
Author
|
I remain at disposal for any further refinement of the code, to improve the evaluation of the signal and event loss |
Cristian-Moscatelli
requested review from
HorstMa,
alibuild,
fmazzasc,
maciacco,
mpuccio,
omvazque and
skundu692
as code owners
mpuccio
requested changes
Feb 25, 2026
Collaborator
mpuccio
left a comment
mpuccio
left a comment
There was a problem hiding this comment.
Dear @Cristian-Moscatelli,
I think what would be best here is to track the selections in a bit mask that we can store in the gen particles. See the comments below for a few more details.
Contributor
Author
|
Thank you for your comment. I will work to refine the task including your suggestions |
Collaborator
Cristian-Moscatelli
requested review from
abmodak,
dmallick2,
ercolessi,
gbencedi,
prottayCMT,
romainschotter and
smaff92
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the selection criteria for generated events (MC collisions) in the task NucleiSpectra.cxx (PWGLF/TableProducer/Nuspex). Previously, no selections were applied to generated events. I applied the following requirements:
Additionally, I replaced the hardcoded triggerList (line 459) with a configurable parameter (line 339). The default value (fHe) is left unvaried.